-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce governance_getRewardsAccumulated API #1848
Introduce governance_getRewardsAccumulated API #1848
Conversation
Sorry for the late. |
@kjeom Yes. I don't understand what exactly you mean "klaytn RPC specification" by, though |
@JayChoi1736 @nohkwak @toniya-klaytn @kjeom Code owners, please review this |
I mean you want to open publicly this API in klaytn docs |
@kjeom Yes. The explanation of this API will be updated when the new version released |
Introduce governance_getRewardsAccumulated API
Proposed changes
PublicGovernanceAPI
toGovernanceAPI
because it is not for the public useThe API returns accumulated reward information in a given block range. Since the method requires heavy storage IO, the method is assigned to
governance
namespace.The example
request payload
response payload
The output example
Types of changes
Please put an x in the boxes related to your change.
Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.
$ make test
)Related issues
Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...