Skip to content
This repository has been archived by the owner on Jul 23, 2024. It is now read-only.

Handling receipt with status and gas correctly #701

Merged
merged 1 commit into from
Aug 28, 2022

Conversation

jimni1222
Copy link
Contributor

Proposed changes

This PR fixes a bug that return an error (ran out of gas) when gas in tx is same with gasUsed in receipt even transaction receipt status is true.
So i changed comparison logic from gasProvided !== receipt.gas to gasProvided >= receipt.gas

Types of changes

Please put an x in the boxes related to your change.

  • Bugfix
  • New feature or enhancement
  • Others

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING GUIDELINES doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Related issues

  • Please leave the issue numbers or links related to this PR here.

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@jimni1222 jimni1222 self-assigned this Aug 25, 2022
@jimni1222 jimni1222 merged commit 9bbe672 into klaytn:dev Aug 28, 2022
@jimni1222 jimni1222 deleted the gasUsed branch August 28, 2022 23:52
@github-actions github-actions bot locked and limited conversation to collaborators Aug 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants