Skip to content
This repository has been archived by the owner on Jul 23, 2024. It is now read-only.

[API] Added getParams API at governance and klay namespaces #740

Merged
merged 3 commits into from
Mar 16, 2023

Conversation

hyunsooda
Copy link
Contributor

Proposed changes

Do not forget to update caver-java as well.

Types of changes

Please put an x in the boxes related to your change.

  • Bugfix
  • New feature or enhancement
  • Others

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING GUIDELINES doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Related issues

  • Please leave the issue numbers or links related to this PR here.

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@CLAassistant
Copy link

CLAassistant commented Mar 3, 2023

CLA assistant check
All committers have signed the CLA.

@nohkwak
Copy link
Member

nohkwak commented Mar 13, 2023

@hyunsooda
image

In the document above shared by @ian, it is written that both getItemAt and getParams should be supported in version 1.10.2.
Please, keep getItemAt supported until the next version and check CLA.

@nohkwak
Copy link
Member

nohkwak commented Mar 13, 2023

When I reviewed it again, I saw that both APIs are still supported, only the test cases are missing.
Please ignore the comments above.

In the PR title, it seems to be applied to the klay namespace as well,
It is not added to the packages/caver-rpc/src/klay.js file.
Please confirm.

Thank you.

@hyunsooda
Copy link
Contributor Author

Added missing klay namespace in JS binding. Thanks.

Copy link
Member

@nohkwak nohkwak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nohkwak nohkwak merged commit ff2f222 into klaytn:dev Mar 16, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Mar 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants