Added checkvalue function and testcase for AddVote api #1109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mckim19
requested review from
aidan-kwon,
hqjang-pepper,
jeongkyun-oh,
KimKyungup and
yoomee1313
as code owners
governance/handler.go
Outdated
Comment on lines
173
to
182
| if key == "istanbul.committeesize" && val == uint64(0) { | ||
| return false | ||
| } | ||
| if key == "reward.minimumstake" { | ||
| if v, ok := new(big.Int).SetString(val.(string), 10); ok { | ||
| if v.Cmp(common.Big0) <= 0 { | ||
| return false | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
Why do you check only for these 2 governance items?
Are other items good to go with no value-check in this function?
There was a problem hiding this comment.
Other items can be discussed and added if there are problems.
hqjang-pepper
previously approved these changes
Jan 12, 2022
yoomee1313
previously approved these changes
Jan 13, 2022
yoomee1313
reviewed
Jan 13, 2022
mckim19
dismissed stale reviews from yoomee1313 and hqjang-pepper
via
947a75f
yoomee1313
approved these changes
Jan 13, 2022
aeharvlee
reviewed
Jan 14, 2022
aeharvlee
approved these changes
Jan 14, 2022
Codecov Report
@@ Coverage Diff @@
## dev #1109 +/- ##
==========================================
+ Coverage 61.30% 61.34% +0.04%
==========================================
Files 478 478
Lines 62618 62620 +2
==========================================
+ Hits 38386 38413 +27
+ Misses 21512 21489 -23
+ Partials 2720 2718 -2
Continue to review full report at Codecov.
|
hqjang-pepper
approved these changes
Jan 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This PR implemented function to check the value of AddVote api and added test cases for AddVote function.
In the previous governance voting, voting was possible with a value that should not be applied.
Currently, if an api call is made for an invalid value as shown below, the call is blocked.
AS-IS
TO-BE
Closes #1107
Types of changes
Please put an x in the boxes related to your change.
Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.
$ make test)Related issues
Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...