Skip to content
This repository has been archived by the owner on Aug 19, 2024. It is now read-only.

homi: set baseFeeDominator flag default value to proper value #1538

Merged

Conversation

yoomee1313
Copy link
Contributor

Proposed changes

  • set baseFeeDominator flag default value to proper value

Types of changes

Please put an x in the boxes related to your change.

  • Bugfix
  • New feature or enhancement
  • Others

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING GUIDELINES doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes ($ make test)
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Related issues

  • Please leave the issue numbers or links related to this PR here.

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@yoomee1313 yoomee1313 marked this pull request as ready for review July 20, 2022 05:12
@yoomee1313 yoomee1313 changed the title homi: re-configure default baseFeeDominator homi: set baseFeeDominator flag default value to proper value Jul 20, 2022
@kjeom kjeom added this to the v1.9.0 (Magma) milestone Jul 20, 2022
@kjeom kjeom added the need to merge Need to merge for the next time label Jul 20, 2022
@yoomee1313 yoomee1313 merged commit 85adf95 into klaytn:dev Jul 20, 2022
@yoomee1313 yoomee1313 deleted the flag-basefeedominator-default-value-fix branch July 20, 2022 09:21
@blukat29 blukat29 removed the need to merge Need to merge for the next time label Feb 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants