Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hardfork blocks to chainConfig APIs #1724

Merged
merged 2 commits into from Nov 28, 2022
Merged

Conversation

ian0371
Copy link
Contributor

@ian0371 ian0371 commented Nov 24, 2022

Proposed changes

governance_chainConfig and governance_chainConfigAt returns hardfork numbers

Types of changes

Please put an x in the boxes related to your change.

  • Bugfix
  • New feature or enhancement
  • Others

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING GUIDELINES doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes ($ make test)
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Related issues

  • Please leave the issue numbers or links related to this PR here.

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

blukat29
blukat29 previously approved these changes Nov 24, 2022
@blukat29 blukat29 added the need to merge Need to merge for the next time label Nov 24, 2022
@ian0371 ian0371 merged commit 37b15b6 into klaytn:dev Nov 28, 2022
@blukat29 blukat29 removed the need to merge Need to merge for the next time label Nov 28, 2022
@blukat29 blukat29 mentioned this pull request Dec 1, 2022
31 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants