Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add hardfork blocks to chainConfig APIs #1724

Merged
merged 2 commits into from Nov 28, 2022
Merged

Add hardfork blocks to chainConfig APIs #1724

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4913dcf
Add hardfork blocks to chainConfig APIs
ian0371 Nov 24, 2022
2c536f8
Add ChainID to chainConfig APIs
ian0371 Nov 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
12 changes: 11 additions & 1 deletion governance/api.go
View file
Open in desktop
Expand Up @@ -284,7 +284,17 @@ func (api *PublicGovernanceAPI) chainConfigAt(num *rpc.BlockNumber) *params.Chai
if err != nil {
return nil
}
return pset.ToChainConfig()

latestConfig := api.governance.BlockChain().Config()
config := pset.ToChainConfig()
ian0371 marked this conversation as resolved.
Show resolved Hide resolved
config.ChainID = latestConfig.ChainID
config.IstanbulCompatibleBlock = latestConfig.IstanbulCompatibleBlock
config.LondonCompatibleBlock = latestConfig.LondonCompatibleBlock
config.EthTxTypeCompatibleBlock = latestConfig.EthTxTypeCompatibleBlock
config.MagmaCompatibleBlock = latestConfig.MagmaCompatibleBlock
config.KoreCompatibleBlock = latestConfig.KoreCompatibleBlock

return config
}

func (api *PublicGovernanceAPI) NodeAddress() common.Address {
Expand Down