Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pass chainConfig for calculating effectiveGasPrice #2171

Merged
merged 1 commit into from
May 23, 2024

Conversation

yoomee1313
Copy link
Contributor

@yoomee1313 yoomee1313 commented May 16, 2024

Proposed changes

  • This PR passes chainConfig through newEVMTxContext and newRPCTransaction (newEthRPCTransaction) to calculate the effectiveGasPrice.
  • This chainConfig pass PR is a part of kip-162 implementation, but take it on seperate PR due to its amount.
  • For the reference, adding an effectiveGasPrice field at Receipt and Transaction(Message) is discussed before to replace this PR, but concluded there's not much need for it even though this way degrades the readability. Actually, effectiveGasPrice field will not be used for consensus purpose and TransactionArgs refactoring also cannot optimize the change.

Types of changes

Please put an x in the boxes related to your change.

  • Bugfix
  • New feature or enhancement
  • Others

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING GUIDELINES doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes ($ make test)
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Related issues

  • Please leave the issue numbers or links related to this PR here.

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

api/api_ethereum.go Outdated Show resolved Hide resolved
blockchain/types/transaction.go Show resolved Hide resolved
blockchain/state_transition.go Outdated Show resolved Hide resolved
@yoomee1313 yoomee1313 changed the title kip162: reward gasFeeCap as a proposer tip pass chainConfig for calculating effectiveGasPrice May 23, 2024
@yoomee1313 yoomee1313 marked this pull request as ready for review May 23, 2024 05:51
@blukat29 blukat29 merged commit cb95972 into klaytn:dev May 23, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants