Skip to content
This repository has been archived by the owner on Aug 19, 2024. It is now read-only.

parameterize triesInMemory #555

Merged
merged 2 commits into from
Jun 24, 2020
Merged

Conversation

joowon-byun
Copy link
Contributor

Proposed changes

  • triesInMemory can be changed by parameter.
    • parameter name: state.tries-in-memory
    • default value: 4

Types of changes

Please put an x in the boxes related to your change.

  • Bugfix
  • New feature or enhancement
  • Others

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING GUIDELINES doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes ($ make test)
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Related issues

Further comments

Increasing triesInMemory can increase memory usage. The below result shows memory usage differences when TPS is 2500.
CN0: 4 tries, CN1: 64 tries, CN2: 128 tries, CN3: 256 tries
Screen Shot 2020-06-23 at 10 48 47 AM
Screen Shot 2020-06-23 at 10 49 06 AM

ehnuje
ehnuje previously approved these changes Jun 23, 2020
Copy link
Contributor

@ehnuje ehnuje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

cmd/utils/flags.go Outdated Show resolved Hide resolved
aidan-kwon
aidan-kwon previously approved these changes Jun 23, 2020
Copy link
Member

@aidan-kwon aidan-kwon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except for a minor thing

@joowon-byun joowon-byun dismissed stale reviews from aidan-kwon and ehnuje via 27ff26c June 23, 2020 07:05
@KimKyungup KimKyungup requested a review from ehnuje June 24, 2020 04:12
@joowon-byun joowon-byun merged commit 0305c72 into klaytn:dev Jun 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants