This repository has been archived by the owner on Aug 19, 2024. It is now read-only.
Implemented Kafka client #685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeongkyun-oh
requested review from
aidan-kwon,
ehnuje,
KimKyungup,
kjhman21,
joowon-byun and
yoomee1313
as code owners
jeongkyun-oh
force-pushed
the
KLT-135-impl-kafka-broker2
branch
from
786f6a6
to
fee0356
Compare
9 tasks
ehnuje
reviewed
Sep 24, 2020
joowon-byun
reviewed
Sep 24, 2020
jeongkyun-oh
force-pushed
the
KLT-135-impl-kafka-broker2
branch
from
1f615dd
to
eb627a0
Compare
jeongkyun-oh
force-pushed
the
KLT-135-impl-kafka-broker2
branch
from
eb627a0
to
89e7621
Compare
ehnuje
reviewed
Sep 24, 2020
joowon-byun
approved these changes
Sep 24, 2020
aidan-kwon
approved these changes
Sep 24, 2020
ehnuje
reviewed
Sep 24, 2020
| @@ -347,6 +347,7 @@ func doFmt(cmdline []string) { | |||
| "--tests", | |||
| "--disable-all", | |||
| "--enable=gofmt", | |||
| "--timeout=2m", | |||
There was a problem hiding this comment.
Is this related to this PR?
There was a problem hiding this comment.
Without this, the linter is failed with timeout error.
ehnuje
approved these changes
Sep 24, 2020
yoomee1313
reviewed
Sep 24, 2020
| type KafkaConfig struct { | ||
| saramaConfig *sarama.Config // kafka client configurations. | ||
| brokers []string // brokers is a list of broker URLs. | ||
| partitions int32 // partitions is the number of partitions of a topic. |
There was a problem hiding this comment.
To make sure what I understand is correct, partition is a unit of distributed processing and replica is a unit of replication, right?
There was a problem hiding this comment.
So, a topic is kinda message queue which consists of several partitions to process message in parallel. The replica(= replication factor) is how many partitions are copied to other brokers.
For example, topic1(T1) has three partitions. Broker1 is a leader for topic1-partition1(T1-P1) and the other brokers have the replicated T1-P1.
yoomee1313
approved these changes
Sep 24, 2020
KimKyungup
approved these changes
Sep 24, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Publish,CreateTopic,DeleteTopic,ListTopicsare implemented and used later on.Types of changes
Please put an x in the boxes related to your change.
Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.
$ make test)