This repository has been archived by the owner on Aug 19, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 189
Added a new API debug.getModifiedStorageNodesByNumber #742
Merged
ehnuje
merged 5 commits into
klaytn:dev
from
ehnuje:1111-added-debug-getModifiedStorageNodesByNumber
Nov 15, 2020
Merged
Added a new API debug.getModifiedStorageNodesByNumber #742
ehnuje
merged 5 commits into
klaytn:dev
from
ehnuje:1111-added-debug-getModifiedStorageNodesByNumber
Nov 15, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aidan-kwon
reviewed
Nov 12, 2020
aidan-kwon
reviewed
Nov 12, 2020
aidan-kwon
reviewed
Nov 12, 2020
yoomee1313
reviewed
Nov 12, 2020
KimKyungup
previously approved these changes
Nov 12, 2020
aidan-kwon
reviewed
Nov 12, 2020
aidan-kwon
previously approved these changes
Nov 12, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM except for a minor thing
KimKyungup
approved these changes
Nov 12, 2020
yoomee1313
approved these changes
Nov 12, 2020
aidan-kwon
approved these changes
Nov 13, 2020
jeongkyun-oh
approved these changes
Nov 13, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
debug.getModifiedStorageNodesByNumber(contractAddr, startBlockNum, endBlockNum, returnDiffList)
to track the modified contract storage trie nodes between the two blocks specified.endBlockNum
can be omitted and if so, the difference between thestartBlockNum-1
andstartBlockNum
will be calculated.returnDiffList
can be omitted and if so, the list of the changed nodes will be only printed to the log, not to the console. If it is entered as true, the list of the nodes will be also printed to the console.Types of changes
Please put an x in the boxes related to your change.
Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.
$ make test
)Related issues
Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...