Skip to content
This repository has been archived by the owner on Aug 19, 2024. It is now read-only.

Added a new API debug.getModifiedStorageNodesByNumber #742

Merged

Conversation

ehnuje
Copy link
Contributor

@ehnuje ehnuje commented Nov 11, 2020

Proposed changes

  • Added a new debug API, debug.getModifiedStorageNodesByNumber(contractAddr, startBlockNum, endBlockNum, returnDiffList) to track the modified contract storage trie nodes between the two blocks specified.
  • endBlockNum can be omitted and if so, the difference between the startBlockNum-1 and startBlockNum will be calculated.
  • returnDiffList can be omitted and if so, the list of the changed nodes will be only printed to the log, not to the console. If it is entered as true, the list of the nodes will be also printed to the console.

Types of changes

Please put an x in the boxes related to your change.

  • Bugfix
  • New feature or enhancement
  • Others

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING GUIDELINES doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes ($ make test)
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Related issues

  • Please leave the issue numbers or links related to this PR here.

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

node/cn/api.go Outdated Show resolved Hide resolved
node/cn/api.go Outdated Show resolved Hide resolved
node/cn/api.go Outdated Show resolved Hide resolved
node/cn/api.go Outdated Show resolved Hide resolved
KimKyungup
KimKyungup previously approved these changes Nov 12, 2020
node/cn/api.go Outdated Show resolved Hide resolved
aidan-kwon
aidan-kwon previously approved these changes Nov 12, 2020
Copy link
Member

@aidan-kwon aidan-kwon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except for a minor thing

@ehnuje ehnuje merged commit c35a547 into klaytn:dev Nov 15, 2020
@ehnuje ehnuje deleted the 1111-added-debug-getModifiedStorageNodesByNumber branch November 15, 2020 23:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants