Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable tx prefetcher for multiple blocks #916

Merged
merged 2 commits into from
Mar 8, 2021

Conversation

kjhman21
Copy link
Collaborator

@kjhman21 kjhman21 commented Mar 8, 2021

Proposed changes

  • Previously, the tx prefetcher was enabled when only one block is passed into BlockChain.insertChain().
  • After sync test, we found that the tx prefetcher is useful when multiple blocks are passed to that function.
  • Hence, we enable tx prefetcher if multiple blocks are passed.

Types of changes

Please put an x in the boxes related to your change.

  • Bugfix
  • New feature or enhancement
  • Others

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING GUIDELINES doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes ($ make test)
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Related issues

@@ -1682,14 +1682,13 @@ func (bc *BlockChain) insertChain(chain types.Blocks) (int, []interface{}, []*ty

if bc.cacheConfig.TrieNodeCacheConfig.NumFetcherPrefetchWorker > 0 {
// if fetcher works and only a block is given, use prefetchTxWorker
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change or remove the comment accordingly 😅

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated. Please take a look. :)

blockchain/blockchain.go Outdated Show resolved Hide resolved
@kjhman21 kjhman21 merged commit 0bde8ce into klaytn:dev Mar 8, 2021
@kjhman21 kjhman21 deleted the enable_multi_insert branch March 8, 2021 05:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants