Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move prefetcher execution as early as possible #918

Merged
merged 2 commits into from
Mar 10, 2021

Conversation

kjhman21
Copy link
Collaborator

@kjhman21 kjhman21 commented Mar 9, 2021

Proposed changes

  • Prefetching should be executed as early as possible.
  • This commit moves the prefetch trigger to the top of the for loop without changing code semantics.
  • We found that it shows little bit performance improvement. See below snapshot from grafana. (from block number 51786905)

image
image (5)

Types of changes

Please put an x in the boxes related to your change.

  • Bugfix
  • New feature or enhancement
  • Others

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING GUIDELINES doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes ($ make test)
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Related issues

ehnuje
ehnuje previously approved these changes Mar 9, 2021
Copy link
Contributor

@ehnuje ehnuje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

KimKyungup
KimKyungup previously approved these changes Mar 9, 2021
blockchain/blockchain.go Outdated Show resolved Hide resolved
joowon-byun
joowon-byun previously approved these changes Mar 9, 2021
@kjhman21 kjhman21 dismissed stale reviews from joowon-byun, KimKyungup, and ehnuje via 9369561 March 9, 2021 09:21
@kjhman21 kjhman21 requested a review from ehnuje March 9, 2021 15:52
@KimKyungup KimKyungup merged commit 3b47912 into klaytn:dev Mar 10, 2021
@kjhman21 kjhman21 deleted the hoist_prefetch branch March 10, 2021 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants