Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanups and Updates #245

Merged
merged 16 commits into from Nov 15, 2018
Merged

Cleanups and Updates #245

merged 16 commits into from Nov 15, 2018

Conversation

rejas
Copy link
Contributor

@rejas rejas commented Oct 14, 2018

No description provided.

@rejas rejas requested a review from joakimbeng November 9, 2018 11:29
Copy link
Member

@joakimbeng joakimbeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on this!
Just a tiny change..

package.json Outdated
@@ -1,7 +1,16 @@
{
"name": "gulp-inject",
"version": "0.0.0-development",
"version": "4.3.2",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"version": "4.3.2",
"version": "0.0.0-development",

Revert this change, semantic-release handles the versioning without this

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done :-)

Copy link
Member

@joakimbeng joakimbeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, too fast on the button...

@joakimbeng joakimbeng merged commit ff8f9b0 into master Nov 15, 2018
@joakimbeng joakimbeng deleted the cleanups branch November 15, 2018 11:22
@joakimbeng
Copy link
Member

🎉 This PR is included in version 4.3.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants