Support blocking untrusted operations #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I considered integrating this a bit deeper, allowing for things like: vips.Operation.block(vips.Image.pngsave, true);
vips.Image.jpegsave.block(true);
vips.Image.jpegsave.block(); // returns true
vips.Image.jpegsave.untrusted(); // returns falseBut AFAICT it would require a massive amount of work, and I wasn't even sure if it would be desirable, given that it is pretty different from the core |
kleisauke
reviewed
Sep 4, 2022
Co-authored-by: Kleis Auke Wolthuizen <github@kleisauke.nl>
Co-authored-by: Kleis Auke Wolthuizen <github@kleisauke.nl>
Co-authored-by: Kleis Auke Wolthuizen <github@kleisauke.nl>
To match build/preamble
Co-authored-by: Kleis Auke Wolthuizen <github@kleisauke.nl>
Co-authored-by: Kleis Auke Wolthuizen <github@kleisauke.nl>
Co-authored-by: Kleis Auke Wolthuizen <github@kleisauke.nl>
Co-authored-by: Kleis Auke Wolthuizen <github@kleisauke.nl>
- Ensure `test_block.js` suite is also being tested on the browser.
- Move `before` and `after{,Each}` hooks inside the `describe` block.
- Simplify `blockUntrusted` test.
- Escape boolean types between grave accents in `vips.d.ts`.
jcupitt
added a commit
to libvips/libvips
that referenced
this pull request
Sep 4, 2022
We could return an operation from cache even after the operatuion had been blocked. This was harmless, but could cause confusion. see kleisauke/wasm-vips#24
Non-functional change.
kleisauke
approved these changes
Sep 4, 2022
kleisauke
added a commit
that referenced
this pull request
Sep 4, 2022
RReverser
pushed a commit
to RReverser/libvips
that referenced
this pull request
Oct 28, 2022
We could return an operation from cache even after the operatuion had been blocked. This was harmless, but could cause confusion. see kleisauke/wasm-vips#24
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support blocking untrusted and arbitrary operations with
vips_block_untrusted_setandvips_operation_block_set:Note that it was already possible to use
vips_block_untrusted_setbefore, by setting themodule.ENV.VIPS_BLOCK_UNTRUSTEDparameter on initialization.Related: #21 (comment)