Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate versions.json #55

Merged
merged 1 commit into from
Nov 1, 2023
Merged

Conversation

lovell
Copy link
Contributor

@lovell lovell commented Oct 31, 2023

I've started integrating lovell/sharp#3522 and I think generating a versions.json at build time would be quite useful, if only to make things consistent with the other scripts that generate prebuilt libvips binaries. Any thoughts?

Copy link
Owner

@kleisauke kleisauke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! This would indeed be useful to add. I left a suggestion inline, but otherwise this looks good to me.

build.sh Outdated Show resolved Hide resolved
@lovell lovell marked this pull request as ready for review November 1, 2023 16:14
Copy link
Owner

@kleisauke kleisauke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@kleisauke kleisauke merged commit b98d72a into kleisauke:master Nov 1, 2023
4 checks passed
@kleisauke
Copy link
Owner

Commit bd21b3d ensures that this file is also distributed in wasm-vips. This will be in v0.0.6.

@lovell lovell deleted the add-versions-json branch November 1, 2023 19:44
@kleisauke kleisauke added this to the v0.0.6 milestone Nov 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants