Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed to use named constructor 'from_parent' #189

Closed
wants to merge 1 commit into from
Closed

Changed to use named constructor 'from_parent' #189

wants to merge 1 commit into from

Conversation

ubaumann
Copy link

@ubaumann ubaumann commented Aug 2, 2020

@ubaumann
Copy link
Author

ubaumann commented Aug 2, 2020

Fix for #187 and #177

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.3%) to 77.969% when pulling 84cbc4c on ubaumann:from_parent into f436ccc on klen:develop.

@felixonmars
Copy link

There is one test failure after this patch, not sure if it's related:

=================================== FAILURES ===================================
______________________________ test_ignore_select ______________________________

    def test_ignore_select():
        options = parse_options()
        options.ignore = ['E301', 'D102']
        options.linters = ['pycodestyle', 'pydocstyle', 'pyflakes', 'mccabe']
        errors = run('dummy.py', options=options)
>       assert len(errors) == 32
E       assert 33 == 32
E        +  where 33 = len([<Error: D100 pydocstyle>, <Error: E265 pycodestyle>, <Error: E265 pycodestyle>, <Error: D101 pydocstyle>, <Error: D107 pydocstyle>, <Error: D105 pydocstyle>, ...])

tests/test_config.py:31: AssertionError

@ubaumann
Copy link
Author

Checkout this pull request: #188
It fixes the failing test

@felixonmars
Copy link

Ah great... Thanks a lot!

michael-k added a commit to michael-k/pylava that referenced this pull request Sep 28, 2020
Fixes pytest 6.1.0 compatibility
Taken from klen/pylama#189

Co-authored-by: ubaumann <github@m.ubaumann.ch>
@hkam40k
Copy link

hkam40k commented Dec 18, 2020

Is this going to get merged any time soon?

@klen
Copy link
Owner

klen commented Nov 24, 2021

@ubaumann Thank you for the PR. Finally the problem has been fixed.

@klen klen closed this Nov 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants