Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Loading bar throws an exception on unmount if not using refs #2

Closed
codinronan opened this issue Apr 24, 2019 · 1 comment
Closed

Loading bar throws an exception on unmount if not using refs #2

codinronan opened this issue Apr 24, 2019 · 1 comment
Labels
bug Something isn't working

Comments

@codinronan
Copy link

Hi there,

There's an issue introduced in your latest changes:

https://github.com/klendi/react-top-loading-bar/blame/bc6077646e3a38d70f6d3e7e0ce0310f719f9f8f/src/index.js#L115

If the consumer does not use the ref property, this line of code throws an exception on unmount, crashing the page.
@klendi klendi added the bug Something isn't working label Apr 25, 2019
klendi added a commit that referenced this issue Apr 25, 2019
@klendi
Fix a bug referenced at issue #2, loader would crash if you would not…
2ee315a 
… use refs in unmountcomponent
@klendi
Copy link
Owner

klendi commented Apr 25, 2019 •
edited
Loading

Thank you for this bug report. Fixed it and published fresh package to npm.
Feel free to reopen if you encounter any other issues.

@klendi klendi closed this as completed Apr 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@codinronan @klendi