Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(web)/dynamic history #29

Merged
merged 16 commits into from
May 21, 2024
Merged

Feat(web)/dynamic history #29

merged 16 commits into from
May 21, 2024

Conversation

Harman-singh-waraich
Copy link
Contributor

@Harman-singh-waraich Harman-singh-waraich commented May 15, 2024

PR-Codex overview

This PR introduces various updates related to registries, items, and modals. It includes changes in status, pagination, styling adjustments, and new utility functions.

Detailed summary

  • Updated status values and queries for registries and items
  • Styling adjustments in components like ItemField, StyledModal, and HistorySkeletonContainer
  • Addition of a new utility function for date formatting
  • Pagination control added to RegistriesDisplay and RegistriesGrid
  • Improved handling of requests and submissions in Curate.ts and Request.ts
  • Refactored components like SubmitList, Tabs, and AliasDisplay for better functionality

The following files were skipped due to too many changes: subgraph/src/entities/Request.ts, web/src/context/SubmitListContext.tsx, web/src/hooks/queries/useRequestsQuery.ts, web/src/pages/AllLists/StyledBreadcrumb.tsx, web/src/components/RegistryCard/RegistryInfo.tsx, web/src/components/Modal/Buttons/index.tsx, web/src/app.tsx, web/src/components/ActionButton/Modal/index.tsx, web/src/context/SubmitItemContext.tsx, web/src/components/ActionButton/ExecuteButton.tsx, web/src/pages/Home/Highlights/index.tsx, web/src/components/RegistryCard/StatusBanner.tsx, web/src/pages/AllLists/ItemDisplay/index.tsx, web/src/pages/AllLists/RegistriesFetcher.tsx, web/src/components/ActionButton/index.tsx, web/src/consts/index.ts, web/src/components/ActionButton/Modal/EvidenceUpload.tsx, web/src/pages/AllLists/RegistryDetails/index.tsx, web/src/components/ItemInformationCard/index.tsx, web/src/components/HistoryDisplay/index.tsx, web/src/components/ActionButton/Modal/ResubmitModal.tsx, web/src/components/ActionButton/Modal/RemoveModal.tsx, web/src/components/ActionButton/Modal/ChallengeItemModal.tsx, web/src/components/InformationCard/index.tsx

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

netlify bot commented May 15, 2024

Deploy Preview for curate-v2 ready!

Name Link
🔨 Latest commit c1e2cfa
🔍 Latest deploy log https://app.netlify.com/sites/curate-v2/deploys/664ca6ccdec6d7000860f1bd
😎 Deploy Preview https://deploy-preview-29--curate-v2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@kemuru kemuru self-requested a review May 15, 2024 11:25
@kemuru
Copy link
Contributor

kemuru commented May 15, 2024

when a list or an item's description is too long, it causes the right content (item Id, status, etherscan logo...) to go below the description. I thought it would be nicer if the description had a maximum width it can expand (like 60%, or 50%, or whatever looks better) and if it goes beyond that then the height of the description dynamically increases and it goes to the next line, instead of continuing to the right

image

@kemuru kemuru self-requested a review May 15, 2024 19:10
kemuru
kemuru previously approved these changes May 15, 2024
Copy link
Contributor

@kemuru kemuru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, we can improve the comment I put later in a next PR

kemuru
kemuru previously approved these changes May 17, 2024
Copy link
Contributor

@kemuru kemuru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

coderabbitai bot commented May 21, 2024

Important

Review Skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@kemuru kemuru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kemuru kemuru merged commit 0c50437 into master May 21, 2024
6 checks passed
@kemuru kemuru deleted the feat(web)/dynamic-history branch May 21, 2024 13:56
@jaybuidl jaybuidl linked an issue Jun 3, 2024 that may be closed by this pull request
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IPFS retrieval: endpoint update
2 participants