Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update-subgraph-queries #338

Merged
merged 7 commits into from
May 30, 2024
Merged

Conversation

Harman-singh-waraich
Copy link
Contributor

@Harman-singh-waraich Harman-singh-waraich commented May 17, 2024

closes #331

@Harman-singh-waraich Harman-singh-waraich marked this pull request as ready for review May 18, 2024 08:29
@kemuru kemuru self-requested a review May 29, 2024 19:14
Copy link
Collaborator

@kemuru kemuru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but searching is not working now,

The entry I was trying to search for specifically is in Address Tags on Gnosis and one of the previously broken entries by ipfs.cat that now should work with the subgraph migration to ipfs data sources

https://deploy-preview-338--kleros-curate.netlify.app/tcr/100/0x66260C69d03837016d88c9877e61e08Ef74C59F2/0xb7ee4bbe0e2932357fdf7a7648ce3918e8944755aeed33fde56b09bcf87d223c

Once this entry shows up in the search, everything should be good for merge.

@kemuru kemuru self-requested a review May 30, 2024 08:56
Copy link
Collaborator

@kemuru kemuru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Copy link

sonarcloud bot commented May 30, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@kemuru kemuru merged commit 9e0914c into master May 30, 2024
7 checks passed
@kemuru kemuru deleted the chore/migrate-subgraph-and-queries branch May 30, 2024 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migration to TheGraph network
3 participants