Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: point-upload-to-ipfs-function-to-court-function #340

Merged
merged 4 commits into from
Jun 12, 2024

Conversation

Harman-singh-waraich
Copy link
Contributor

  • updates upload-form-data-to-ipfs to use the uplod-to-ipfs function from court-functions repo
  • removes the local netlify functions

Thing to note while reviewing :

  • The ipfs-publish function has a check for extensions based on which it pins to graph node
  • Make sure all the files required by subgraph are pinned to node, was made sure by me, would be nice to have a second review on it.

@jaybuidl jaybuidl requested a review from kemuru June 12, 2024 11:51
@jaybuidl jaybuidl linked an issue Jun 12, 2024 that may be closed by this pull request
Copy link
Collaborator

@kemuru kemuru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried uploading a file in the "Create a List" section, getting the error

POST https://deploy-preview-340--kleros-curate.netlify.app/undefined/.netlify/functions/upload-to-ipfs?operation=evidence&pinToGraph=false 404 (Not Found)

image

Copy link

sonarcloud bot commented Jun 12, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@kemuru kemuru self-requested a review June 12, 2024 15:10
Copy link
Collaborator

@kemuru kemuru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kemuru kemuru merged commit c394586 into master Jun 12, 2024
7 checks passed
@kemuru kemuru deleted the chore/upload-to-ipfs-function-point-to-court-functions branch June 12, 2024 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants