-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: use-court-functions-upload-to-ipfs-function #19
Conversation
✅ Deploy Preview for kleros-scout-app ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
||
return fetch(url, { | ||
const url = `${process.env.REACT_APP_COURT_FUNCTIONS_URL}/.netlify/functions/upload-to-ipfs?operation=${operation}&pinToGraph=${pinToGraph}` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we cannot use env variables in this repo I believe. so we might need to hardcode const REACT_APP_COURT_FUNCTIONS_URL = https://kleros-api.netlify.app
in this file/ or create another file for storing global public variables
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For this purpose, i prefer just hardcoding it inside the url itself, as i don't see this api being used anywhere else besides this function
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
No description provided.