-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add method to serialize tron tx to raw hex #40
Conversation
WalkthroughAs atualizações incluem melhorias de segurança, como a atualização do Changes
Poem
TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files ignored due to path filters (1)
Cargo.lock
is excluded by!**/*.lock
Files selected for processing (5)
- .pants-ignore (1 hunks)
- Cargo.toml (1 hunks)
- packages/kos-sdk/src/chains/bitcoin/mod.rs (1 hunks)
- packages/kos-sdk/src/chains/klever/models.rs (2 hunks)
- packages/kos-sdk/src/chains/tron/mod.rs (2 hunks)
Files skipped from review due to trivial changes (2)
- .pants-ignore
- Cargo.toml
Additional comments not posted (2)
packages/kos-sdk/src/chains/bitcoin/mod.rs (1)
299-307
: A funçãoserialize_tx
está bem implementada, com tratamento adequado de erros e uso correto de correspondência de padrões.packages/kos-sdk/src/chains/tron/mod.rs (1)
391-397
: A funçãoserialize_tx_into_raw_hex
está corretamente implementada, com tratamento adequado de erros e uso eficiente da serialização e desserialização.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files ignored due to path filters (1)
Cargo.lock
is excluded by!**/*.lock
Files selected for processing (1)
- deny.toml (1 hunks)
Additional comments not posted (8)
deny.toml (8)
17-17
: Verifique se a versão<=0.22
do pacotebase64
está correta e se há uma justificativa clara para pular esta versão específica, considerando que está relacionada aoopenssl
.
18-18
: Certifique-se de que a versão=0.4.0
do pacoteidna
está correta. Seria útil adicionar um comentário explicando por que esta versão específica está sendo ignorada.
19-19
: Confirme se a versão<=0.52
do pacotewinreg
está correta e se há uma justificativa adequada para pular esta versão.
20-20
: Verifique se a versão<=1.1
do pacotehttp
está correta. Um comentário explicativo sobre a razão para pular esta versão seria benéfico.
21-21
: Confirme se a versão<=1.0.0
do pacotehttp-body
está correta e se há uma justificativa adequada para pular esta versão.
22-22
: Verifique se a versão<=1.3.1
do pacotehyper
está correta. Seria útil adicionar um comentário explicando por que esta versão específica está sendo ignorada.
23-23
: Certifique-se de que a versão<=0.12.4
do pacotereqwest
está correta. Um comentário explicativo sobre a razão para pular esta versão seria benéfico.
24-24
: Confirme se a versão1.0.4
do pacoterustls-pemfile
está correta e se há uma justificativa adequada para pular esta versão.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- packages/kos-sdk/src/chains/klever/models.rs (2 hunks)
Files skipped from review as they are similar to previous changes (1)
- packages/kos-sdk/src/chains/klever/models.rs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- packages/kos-sdk/src/chains/ethereum/mod.rs (2 hunks)
- packages/kos-sdk/src/chains/polygon/mod.rs (2 hunks)
Files skipped from review due to trivial changes (1)
- packages/kos-sdk/src/chains/polygon/mod.rs
Additional comments not posted (3)
packages/kos-sdk/src/chains/ethereum/mod.rs (3)
590-590
: Atualização de dados codificados em hexadecimal.
596-596
: Atualização de hash de transação.
581-581
: Correção de hash de transação.- "fa2b84b45d28888c43c0bda80000e4a4d2040017f3b6e4a31e7d8a4ace27db29" + "fa2b84b45d28888c43c0bda80000e4a4d2040017f3b6e4a31e7d8a4ace27db29"Likely invalid or redundant comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- packages/kos-sdk/src/chains/polygon/mod.rs (5 hunks)
Files skipped from review as they are similar to previous changes (1)
- packages/kos-sdk/src/chains/polygon/mod.rs
Description
add method to serialize tron tx to raw hex
Type of Change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Checklist:
make check
Summary by CodeRabbit
Novos Recursos
Correções de Bugs
Refatoração
ToString
paraResultAccount
eTransferTXRequest
usandostd::fmt::Display
para melhor controle de formatação.Testes