Windows compability improvements #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Windows doesn't default to utf8 encoding which results in potential errors when using windows to build the package. See: https://discuss.python.org/t/pep-597-use-utf-8-for-default-text-file-encoding/1819 https://www.python.org/dev/peps/pep-0597/
As mentioned in #1, anki saves it's databases in APPDATA/Roaming/Anki2 os.getenv provides the path in windows fashion with \\ as seperator which is why i feed the result into Path to convert it into a proper windowspath.
|
Awesome! I didn't know that about the default encoding, seems like this is a problem for almost all of my projects! |
|
@allcontributors please add @exc4l for code |
|
I've put up a pull request to add @exc4l! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in the commits, when building packages on windows it's important that the encoding of the readme is specified.
https://discuss.python.org/t/pep-597-enable-utf-8-mode-by-default-on-windows/3122
Furthermore, when using Ankipandas on windows, collection takes quite some time to find the database due to it starting in the home dictionary.
os.getenv("APPDATA", "~")returns the AppData/Roaming folder with windows typical\\seperators which is why i feed it into pathlib to get a consistent path.C\\Users\\User_name\\AppData\\Roaming/Anki2/might work on it's own but I'm uncertain if it could lead to problems. On Linux this should simply result in~/Anki2