Makefile, admesh as dependency #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you update the readme to state that admesh is no longer included in the file and to reflect the new makefile? |
|
Previously, there was |
|
No, I meant that the build instructions don't currently mention the admesh package and still refer to build.sh |
|
Oh I see. It is better now? |
|
Yes, except I would change "the Makefile script" to "make" |
kliment
added a commit
that referenced
this pull request
Jul 8, 2015
Makefile, admesh as dependency, fixes #9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request consist of following changes:
The admesh package is available in Fedora. From my point of view, it seems to be better to use upstream version of admesh rather than bundling of own version.
The build is done using Makefile. Additionally, It have clean and install target. The opencv libraries are cflags and libs is from pkg-config.
Readme was renamed to README.md and updated have markdown syntax (i.e. it looks pretty on github web page)
This was proposed in #9