Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Detail url filters #70

Merged
merged 49 commits into from
Oct 22, 2023
Merged

Detail url filters #70

merged 49 commits into from
Oct 22, 2023

Conversation

EmilyClare4
Copy link
Collaborator

Changes to the mushroom detail page:

  • Commented out 'lookalikes' field as currently no mushrooms have this data
  • Combined 'Features' tables into one, added new fields from the sampledata file, and applied formatting including adding 'cm' to sizing
  • Should not show attributes where values are null/0 in the Features section
  • Removed nav bar and added header

EmilyClare4 and others added 30 commits October 6, 2023 12:07
@EmilyClare4
functionality for specific mushroom page
b59be50
@EmilyClare4
put all info into table
cef7609
@EmilyClare4
added carousel with correct image path
367ffb6
@EmilyClare4
Added common names heading
3299dff
@EmilyClare4
rough formatting two columns
7dcbef5
@EmilyClare4
all info added
3b7ce0e
@EmilyClare4
added boxes around info
d121141
@EmilyClare4
fixed section spacing
5c19aba
@EmilyClare4
spacing
5f1d9b8
@EmilyClare4
tidying up tables
6e4f109
@EmilyClare4
sampledata
9ed8eab
@EmilyClare4
fixing table data
f80fae6
@EmilyClare4
links back to index with parameters
27171b7
@EmilyClare4
formatting URL
9d34bb6
@EmilyClare4
formatting URL
09ae75b
@EmilyClare4
formatting links
ec4560c
@EmilyClare4
removing description and lookalike links
547f325
@EmilyClare4
format information table
365f61f
@EmilyClare4
remove unused methods
1a83d28
@EmilyClare4
styling page
aa8646e
@EmilyClare4
commenting
c6b2088
@EmilyClare4
spacing
4bc4769
@EmilyClare4
more spacing
e9667f0
@EmilyClare4
updated css formatting
567c65f
@EmilyClare4
tidied up logic for Features box
387e189
@EmilyClare4
fetchData method for mushroom-detail added
0d98f0a
@AdamN2424
route params in Index fix
6da33ff
@joel-yap
added switch statement to apply mushroom card link parameters to inde…
57357f2 
…x filter
@AdamN2424
CapFilter working
83db3ae
@AdamN2424
some url filters working
039fef5
@EmilyClare4 EmilyClare4 self-assigned this Oct 21, 2023
@EmilyClare4 EmilyClare4 added the enhancement New feature or request label Oct 21, 2023
AdamN2424
AdamN2424 approved these changes Oct 22, 2023
View reviewed changes
Copy link
Collaborator

@AdamN2424 AdamN2424 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. All tests working and mushroom-detail-page functioning as intended. Ready to merge

@EmilyClare4 EmilyClare4 merged commit 89cb929 into master Oct 22, 2023
3 of 4 checks passed
@EmilyClare4 EmilyClare4 deleted the detail-url-filters branch October 22, 2023 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AdamN2424 AdamN2424 AdamN2424 approved these changes

@RosieHall RosieHall Awaiting requested review from RosieHall

@joel-yap joel-yap Awaiting requested review from joel-yap

@kloudsoft91 kloudsoft91 Awaiting requested review from kloudsoft91

Assignees

@EmilyClare4 EmilyClare4

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@EmilyClare4 @AdamN2424 @joel-yap @kloudsoft91