Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CSS Snippets section #30

Merged
merged 22 commits into from
Aug 22, 2021
Merged

Update CSS Snippets section #30

merged 22 commits into from
Aug 22, 2021

Conversation

konhi
Copy link
Contributor

@konhi konhi commented Aug 21, 2021

Issue: #29

  • update terminology (snippets instead tweaks, obsidian.css is no more)
  • adds other links related to snippets (feel free to add more if there are any)
  • update current snippets to new style
  • add examples
  • Collapsing Sidebar is broken #34
  • verify if links and metadata are correct

@kmaasrud what do you think about current update? Feel free to suggest any changes. Please let me know if:

  • style in README.md is okay and I can continue updating styles like that
  • style of .css file is okay (I formatted it and added metadata)
  • structure of files is fine

@konhi
Copy link
Contributor Author

konhi commented Aug 21, 2021

image

@kmaasrud kmaasrud marked this pull request as ready for review August 21, 2021 14:23
@kmaasrud
Copy link
Owner

Oops, didn't mean to mark this as ready for review... But no mind, I think that style looks very good, and I like how you've structured the directories 👍

Very much approved 😄

@konhi
Copy link
Contributor Author

konhi commented Aug 21, 2021

That's so cool! By the way, latest Andy Matuschak mode is a plugin, so I'm gonna remove it from snippets.

@kmaasrud
Copy link
Owner

That's so cool! By the way, latest Andy Matuschak mode is a plugin, so I'm gonna remove it from snippets.

Perfect!

@konhi
Copy link
Contributor Author

konhi commented Aug 21, 2021

Actually this style causes problem with id of header, for example:

## Outliner For The Outline and File Explorer by @Shamama & @wonton
causes id to be very long:
outliner-for-the-outline-and-file-explorer-by-shamama--wonton

I think it's better to move author out of heading.

@konhi
Copy link
Contributor Author

konhi commented Aug 21, 2021

@kmaasrud could you please check if Collapsing Sidebar works? I'm not sure if this is desired result 😅
collapse

@kmaasrud
Copy link
Owner

kmaasrud commented Aug 21, 2021

@kmaasrud could you please check if Collapsing Sidebar works? I'm not sure if this is desired result 😅

I don't have my computer at the ready right now, but I fear it might not work, yes... I think I made that CSS snippet, and it was some while ago. They've probably changed the DOM structure since then...

I'll open a separate issue on it, and have it fixed once this PR is done 👍 You can just leave it without an example GIF for now 😊

Edit: Looking at the snippet, I actually think there might be a part of it missing! Either way, I'll have it fixed as a separate issue 😎

@konhi
Copy link
Contributor Author

konhi commented Aug 21, 2021

task-list-preview-relationship-line-correction.css supposed to fix this unaligement between checkboxes and list:

image

I think it got fixed by developers. This is how it looks now without any snippets.

image

Therefore, I'm removing this snippet.

@konhi
Copy link
Contributor Author

konhi commented Aug 22, 2021

@kmaasrud Examples done!

@kmaasrud
Copy link
Owner

God damn, amazing work! Thank you so much for your contribution 😊

@kmaasrud kmaasrud merged commit b2756c2 into kmaasrud:master Aug 22, 2021
@konhi konhi deleted the snippets branch August 23, 2021 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants