Fix asprintf declaration #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you. That fix is fine. The real bug, though, seems to be this line:
|
|
Try again: |
|
(At least according to the man page, "_USE_GNU" should only have one underscore, not two.) |
|
Ah yeah, good catch! |
|
Actually, I confused USE_GNU and GNU_SOURCE. I guess it's actually two underscores. Anyway, I just defined _GNU_SOURCE and removed the custom asprintf implementation altogether: |
13 tasks
orivej-nixos
pushed a commit
to NixOS/nixpkgs
that referenced
this pull request
Nov 13, 2023
Fixes #263505 (broken build) Upstream has fixed this in 2021 (kmatheussen/jack_capture#45) but has made no releases since (kmatheussen/jack_capture#32)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The declaration of
asprintfseems to be causing compilation issues on musl systems (see here). I'm also running into this issue while trying to package this for Alpine Linux. I believe this is becausechar *fmtisn't being declared asconstin the function declaration, and I think it should be (see asprintf man page). This seems to fix theerror: conflicting types for asprintferror that gets thrown while trying to compile on a musl system.