17 remove view will appear (#18)

kmcgill88 · Oct 26, 2018 · 88d5dba · 88d5dba
1 parent 5eb9a3c
commit 88d5dba
Show file tree

Hide file tree

Showing 4 changed files with 25 additions and 10 deletions.
diff --git a/McAdViewControllerExample.xcodeproj/project.pbxproj b/McAdViewControllerExample.xcodeproj/project.pbxproj
@@ -127,7 +127,7 @@
 			isa = PBXProject;
 			attributes = {
 				LastSwiftUpdateCheck = 0830;
-				LastUpgradeCheck = 0920;
+				LastUpgradeCheck = 1000;
 				ORGANIZATIONNAME = "McGill DevTech, LLC";
 				TargetAttributes = {
 					E7E96B131E9731F000CE9639 = {
@@ -268,13 +268,15 @@
 				CLANG_WARN_BOOL_CONVERSION = YES;
 				CLANG_WARN_COMMA = YES;
 				CLANG_WARN_CONSTANT_CONVERSION = YES;
+				CLANG_WARN_DEPRECATED_OBJC_IMPLEMENTATIONS = YES;
 				CLANG_WARN_DIRECT_OBJC_ISA_USAGE = YES_ERROR;
 				CLANG_WARN_DOCUMENTATION_COMMENTS = YES;
 				CLANG_WARN_EMPTY_BODY = YES;
 				CLANG_WARN_ENUM_CONVERSION = YES;
 				CLANG_WARN_INFINITE_RECURSION = YES;
 				CLANG_WARN_INT_CONVERSION = YES;
 				CLANG_WARN_NON_LITERAL_NULL_CONVERSION = YES;
+				CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF = YES;
 				CLANG_WARN_OBJC_LITERAL_CONVERSION = YES;
 				CLANG_WARN_OBJC_ROOT_CLASS = YES_ERROR;
 				CLANG_WARN_RANGE_LOOP_ANALYSIS = YES;
@@ -324,13 +326,15 @@
 				CLANG_WARN_BOOL_CONVERSION = YES;
 				CLANG_WARN_COMMA = YES;
 				CLANG_WARN_CONSTANT_CONVERSION = YES;
+				CLANG_WARN_DEPRECATED_OBJC_IMPLEMENTATIONS = YES;
 				CLANG_WARN_DIRECT_OBJC_ISA_USAGE = YES_ERROR;
 				CLANG_WARN_DOCUMENTATION_COMMENTS = YES;
 				CLANG_WARN_EMPTY_BODY = YES;
 				CLANG_WARN_ENUM_CONVERSION = YES;
 				CLANG_WARN_INFINITE_RECURSION = YES;
 				CLANG_WARN_INT_CONVERSION = YES;
 				CLANG_WARN_NON_LITERAL_NULL_CONVERSION = YES;
+				CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF = YES;
 				CLANG_WARN_OBJC_LITERAL_CONVERSION = YES;
 				CLANG_WARN_OBJC_ROOT_CLASS = YES_ERROR;
 				CLANG_WARN_RANGE_LOOP_ANALYSIS = YES;
@@ -370,7 +374,7 @@
 				PRODUCT_BUNDLE_IDENTIFIER = com.mcgilldevtech.McAdViewControllerExample;
 				PRODUCT_NAME = "$(TARGET_NAME)";
 				SWIFT_SWIFT3_OBJC_INFERENCE = Default;
-				SWIFT_VERSION = 4.0;
+				SWIFT_VERSION = 4.2;
 			};
 			name = Debug;
 		};
@@ -385,7 +389,7 @@
 				PRODUCT_BUNDLE_IDENTIFIER = com.mcgilldevtech.McAdViewControllerExample;
 				PRODUCT_NAME = "$(TARGET_NAME)";
 				SWIFT_SWIFT3_OBJC_INFERENCE = Default;
-				SWIFT_VERSION = 4.0;
+				SWIFT_VERSION = 4.2;
 			};
 			name = Release;
 		};

diff --git a/McAdViewControllerExample.xcworkspace/xcshareddata/IDEWorkspaceChecks.plist b/McAdViewControllerExample.xcworkspace/xcshareddata/IDEWorkspaceChecks.plist
@@ -0,0 +1,8 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
+<plist version="1.0">
+<dict>
+	<key>IDEDidComputeMac32BitWarning</key>
+	<true/>
+</dict>
+</plist>
diff --git a/McAdViewControllerExample/AppDelegate.swift b/McAdViewControllerExample/AppDelegate.swift
@@ -13,9 +13,8 @@ class AppDelegate: UIResponder, UIApplicationDelegate {
 
     var window: UIWindow?
     var mcAdViewController:McAdViewController?
-
-    func application(_ application: UIApplication, didFinishLaunchingWithOptions launchOptions: [UIApplicationLaunchOptionsKey: Any]?) -> Bool {
-
+
+    func application(_ application: UIApplication, didFinishLaunchingWithOptions launchOptions: [UIApplication.LaunchOptionsKey : Any]? = nil) -> Bool {
         window = UIWindow(frame: UIScreen.main.bounds)
 
         let storyboard = UIStoryboard(name: "Main", bundle: nil)
@@ -34,6 +33,7 @@ class AppDelegate: UIResponder, UIApplicationDelegate {
                                                 interstantialAdUnitId: "ca-app-pub-<YOUR INT ID>", // Conditional Optional - Required if bannerAdUnitId not provided
                                                 isBannerBottom: false, // Optional - Default: true
                                                 debug: true) // Optional - Default: false
+
         mcAdViewController?.safeAreaColor = .red
         // Set McAdViewController as the root
         //

diff --git a/McAdViewControllerExample/McAdViewController.swift b/McAdViewControllerExample/McAdViewController.swift
@@ -61,6 +61,10 @@ open class McAdViewController : UIViewController {
         self.interstantialAdUnitId = interstantialAdUnitId
         self.isBannerBottom = isBannerBottom
         self.debug = debug
+
+        // Setup Interstantial Ad if needed
+        //
+        prepareInterstantialAd()
     }
 
     private override init(nibName nibNameOrNil: String?, bundle nibBundleOrNil: Bundle?) {
@@ -96,19 +100,18 @@ open class McAdViewController : UIViewController {
             useContentViewControllerPreferredStatusBarStyle()
         }
 
-        self.addChildViewController(contentController)
+        self.addChild(contentController)
         contentView.addSubview(contentController.view)
-        contentController.didMove(toParentViewController: self)
+        contentController.didMove(toParent: self)
 
         self.view = contentView
     }
 
     open override func viewWillAppear(_ animated: Bool) {
         super.viewWillAppear(animated)
 
-        // Setup Ads if needed
+        // Setup Banner Ad if needed
         //
-        prepareInterstantialAd()
         requestBannerAd()
     }