Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix metric nil pointer panic #706

Merged
merged 3 commits into from
Aug 8, 2024

Conversation

LiZhenCheng9527
Copy link
Collaborator

What type of PR is this?
/kind bug

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #703

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


Signed-off-by: LiZhenCheng9527 <lizhencheng6@huawei.com>
@kmesh-bot kmesh-bot added the kind/bug Something isn't working label Aug 8, 2024
Copy link

codecov bot commented Aug 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.37%. Comparing base (42f3aaa) to head (433592b).
Report is 6 commits behind head on main.

Files Coverage Δ
pkg/controller/telemetry/metric.go 56.36% <100.00%> (+4.76%) ⬆️

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6ede465...433592b. Read the comment docs.

@LiZhenCheng9527
Copy link
Collaborator Author

/cc @hzxuzhonghu

Copy link
Member

@hzxuzhonghu hzxuzhonghu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should add a test

Signed-off-by: LiZhenCheng9527 <lizhencheng6@huawei.com>
hzxuzhonghu
hzxuzhonghu previously approved these changes Aug 8, 2024
Copy link
Member

@hzxuzhonghu hzxuzhonghu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@kmesh-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hzxuzhonghu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: LiZhenCheng9527 <lizhencheng6@huawei.com>
@hzxuzhonghu
Copy link
Member

/lgtm

@kmesh-bot kmesh-bot added the lgtm label Aug 8, 2024
@kmesh-bot kmesh-bot merged commit dda7049 into kmesh-net:main Aug 8, 2024
8 checks passed
@hzxuzhonghu hzxuzhonghu mentioned this pull request Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Kmesh daemon crashed
3 participants