Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coverage v5.0 breaks django-jenkins #374

Open
matthew-hodgins opened this issue Dec 16, 2019 · 2 comments
Open

Coverage v5.0 breaks django-jenkins #374

matthew-hodgins opened this issue Dec 16, 2019 · 2 comments

Comments

@matthew-hodgins
Copy link

The coverage module recently released v5 and since then, django-jenkins seems broken:

Storing coverage info...
Traceback (most recent call last):
  File "/.../local/lib/python2.7/site-packages/django/core/management/__init__.py", line 364, in execute_from_command_line
    utility.execute()
  File "/.../local/lib/python2.7/site-packages/django/core/management/__init__.py", line 356, in execute
    self.fetch_command(subcommand).run_from_argv(self.argv)
  File "/.../local/lib/python2.7/site-packages/django_jenkins-0.110.0-py2.7.egg/django_jenkins/management/commands/jenkins.py", line 47, in run_from_argv
    super(Command, self).run_from_argv(argv)
  File "/.../local/lib/python2.7/site-packages/django/core/management/commands/test.py", line 29, in run_from_argv
    super(Command, self).run_from_argv(argv)
  File "/.../ocal/lib/python2.7/site-packages/django/core/management/base.py", line 283, in run_from_argv
    self.execute(*args, **cmd_options)
  File "/.../local/lib/python2.7/site-packages/django/core/management/base.py", line 330, in execute
    output = self.handle(*args, **options)
  File "/.../local/lib/python2.7/site-packages/django_jenkins-0.110.0-py2.7.egg/django_jenkins/management/commands/jenkins.py", line 116, in handle
    coverage.save(tested_locations, options)
  File "/.../local/lib/python2.7/site-packages/django_jenkins-0.110.0-py2.7.egg/django_jenkins/tasks/with_coverage.py", line 29, in save
    self.coverage.stop()
  File "/.../local/lib/python2.7/site-packages/django_jenkins-0.110.0-py2.7.egg/django_jenkins/tasks/with_coverage.py", line 55, in get_morfs
    return [filename for filename in coverage.data.measured_files()
AttributeError: 'Coverage' object has no attribute 'data'
@matthew-hodgins
Copy link
Author

I tested locally by calling coverage.get_data() instead of coverage.data and it worked properly.

matthew-hodgins pushed a commit to matthew-hodgins/django-jenkins that referenced this issue Dec 16, 2019
coverage changed their CoverageData.data member to _data, exposed via
get_data()
linuxmaniac pushed a commit to linuxmaniac/django-jenkins that referenced this issue Feb 8, 2020
coverage changed their CoverageData.data member to _data, exposed via
get_data()
@ardalanrazavi
Copy link

Any update on this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants