Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

follow Rubocop 1.13.1 #1773

Merged
merged 2 commits into from
Jan 5, 2022
Merged

follow Rubocop 1.13.1 #1773

merged 2 commits into from
Jan 5, 2022

Conversation

kmuto
Copy link
Owner

@kmuto kmuto commented Jan 5, 2022

Rubocop 1.13.1勧告に従ってみます。

@kmuto kmuto requested a review from takahashim January 5, 2022 05:37
@kmuto
Copy link
Owner Author

kmuto commented Jan 5, 2022

@takahashim
先にRuby 3.1 YAML対応を入れないとCIがだめそうですね…
gem.metadata = { 'rubygems_mfa_required' => 'true' } を付けるよう勧告されたのですが、これで問題ないでしょうか。

@takahashim
Copy link
Collaborator

む、では #1767 をマージします!

@takahashim
Copy link
Collaborator

gem.metadata は要らないような気がするんですが、どうでしたっけ…(あっても困りはしなさそう)

@kmuto
Copy link
Owner Author

kmuto commented Jan 5, 2022

ありがとうございます、mfaのは試しに外すと、以下のように怒られるんですよね。

review.gemspec:4:1: C: [Correctable] Gemspec/RequireMFA: metadata['rubygems_mfa_required'] must be set to 'true'.
Gem::Specification.new do |gem| ...

@takahashim
Copy link
Collaborator

これってRuboCopは1.13じゃなくてもっと新しいやつだったりしますか?

@kmuto
Copy link
Owner Author

kmuto commented Jan 5, 2022

は! すいません、1.24.1ですね(なんで1.13だと思ったんだろう…)。

@takahashim
Copy link
Collaborator

なるほど、だとしたら最近追加されたのかもしれません。おそらく問題はないかと思います。

@kmuto kmuto merged commit 9a74efd into master Jan 5, 2022
@kmuto kmuto deleted the rubocop-1.13.1 branch January 5, 2022 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants