rubocop: resolve Performance/RegexpMatch
, Style/SoleNestedConditional
, and Style/CaseEquality
#1783
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rubocopの
Performance/RegexpMatch
,Style/SoleNestedConditional
,Style/CaseEquality
について対応します。Performance/RegexpMatch
は=~
ではなくmatch?
を使うと早い&キャプチャを使わないのが明確化できる、というものです。Style/SoleNestedConditional
はif等のネストをflatにするものですが、confirm
は例外的にネストにさせています。Style/CaseEquality
もコメントで抑制しただけです(IntegerとRangeをうまいことまとめているため)。