Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ElasticSearch設定の外出し #532

Closed
kmycode opened this issue Feb 9, 2024 · 0 comments · Fixed by #650
Closed

ElasticSearch設定の外出し #532

kmycode opened this issue Feb 9, 2024 · 0 comments · Fixed by #650
Labels
cost-high enhancement New feature or request exploring
Milestone
kb12.0

Comments

@kmycode
Copy link
Owner

kmycode commented Feb 9, 2024 •
edited
Loading

欲しい機能

ElasticSearch設定を外部ymlファイルに切り出し、ymlの編集だけでいいようにする

設定のテンプレートをGit管理下に置き、設定テンプレートを複製して指定ファイル名で保存する感じにする（こちらはgitignoreに含める）
プログラムは、指定ファイル名＞テンプレートファイル名、の順に優先して参照する

必要性

  • ElasticSearch設定変更のためだけにRubyソースコードを直接触るのは抵抗感がある
  • 環境によって設定が変わるものをRubyの一部にするうえにGit管理下に置くのも違和感がある
@kmycode kmycode added enhancement New feature or request exploring labels Feb 9, 2024
@kmycode kmycode added this to the kb12.0 milestone Feb 9, 2024
kmycode added a commit that referenced this issue Mar 8, 2024
@kmycode
Change: #532 ElasticSearch設定の外出し
1760ac6
@kmycode kmycode mentioned this issue Mar 8, 2024
Merged
kmycode added a commit that referenced this issue Mar 12, 2024
@kmycode
Change: #532 ElasticSearch設定の外出し (#650)
a8fbcb3 
* Change: #532 ElasticSearch設定の外出し

* バージョンチェック

* 起動時にエラー
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cost-high enhancement New feature or request exploring
Projects
None yet
Milestone
kb12.0
Development

Successfully merging a pull request may close this issue.

Change: #532 ElasticSearch設定の外出し kmycode/mastodon
1 participant
@kmycode