Handle api.slack.com returning invalid JSON responses #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| response = requests.get(url, params=params, verify=True).json() | ||
| _raise_error_if_not_ok(response) | ||
| return response | ||
| return _parse_response(requests.get(url, params=params, verify=True)) |
There was a problem hiding this comment.
Minor thing but I think it's easier to read if we can break this down into two lines:
response = requests.get(url, params=params, verify=True)
return _parse_response(response)
|
just a few minor comments o/w LGTM! |
|
Thanks, pushed the suggested improvements! |
|
Great - thanks! |
kn
added a commit
that referenced
this pull request
Mar 5, 2015
Handle api.slack.com returning invalid JSON responses
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Written quickly while waiting for
api.slack.comto come back online :)