PR for KnackSteem Editor and Refactor of the sidebar component across the Application #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great work on the editor/preview @ogbiyoyosky although I found a minor issue on the editor preview side. The container is not holding images appropriately. Also, a placeholder is needed whenever there is no article or data to be displayed on the homepage. I believe that is pretty much what needs to get fixed on your next PR. |
|
Thanks @onozasi It would be fixed on the next PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For this PR to work, The IPFS Endpoint has to be replaced with the test API used for uploading images.
ref #34