Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All non-async object failed to attach, even if only one fails #7

Closed
ketan-10 opened this issue Sep 8, 2021 · 1 comment
Closed

Comments

@ketan-10
Copy link
Contributor

ketan-10 commented Sep 8, 2021

image

Description
Currently Even if one non-async object fails to load, all non-async object will not be applied.

await Promise.all(promises).then((results) => {

Expected
Browsers Ideally only throw error on script that failed to load and, other get attached successfully.

Examples

    <script data-src="load.js"></script>  <!-- avaliable -->
    <script data-src="load3.js"></script> <!-- *NOT* avaliable -->
    <script data-src="load2.js"></script> <!-- avaliable -->

Result: due to unavailability of load3.js : load1.js and load2.js also failed to attach

@ketan-10
Copy link
Contributor Author

ketan-10 commented Sep 9, 2021

Fixed in fa7a650 Thanks 👍🏽

@ketan-10 ketan-10 closed this as completed Sep 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant