Refactor blob load related error handling in multiple places. #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use `Promise.allSettled()` to capture failures.
- Refactor `_applyOriginal()` and `_applyBlob()` to a single
method `_applyElement()` that fails over the element to the
original URL if the blob is null.
- Make `_getObject()` return a dummy data{} object with null blob
instead of a reject() in case of failed DB+HTTP fetch so that
`_applyElement()` gracefully fails over to the original URL.
- Rename `_getBlob()` to `_getDBblob()` for clarity.
- Add `<script>.onerror()` to not break the load chain in case
a script fails to load.
ketan-10
reviewed
Sep 9, 2021
| // Get the object from the DB and if that fails, fetch() it over HTTP | ||
| // This function should not reject a promise and in the case of failure, | ||
| // will return a dummy data object as if it were fetched from the DB. | ||
| async _getObject (obj) { |
There was a problem hiding this comment.
I see few methods are marked as async even though no await is not used, is there any reason?
There was a problem hiding this comment.
They needn't be anymore. Will clean up in this branch.
|
WIP. Strange issues on Safari continue to persist. |
|
Fixed in fa7a650 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Promise.allSettled()to capture failures._applyOriginal()and_applyBlob()to a singlemethod
_applyElement()that fails over the element to theoriginal URL if the blob is null.
_getObject()return a dummy data{} object with null blobinstead of a reject() in case of failed DB+HTTP fetch so that
_applyElement()gracefully fails over to the original URL._getBlob()to_getDBblob()for clarity.<script>.onerror()to not break the load chain in casea script fails to load.