Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Domain setting catch 22, move setting to config file #346

Closed
alerque opened this issue May 6, 2021 · 2 comments
Closed

Domain setting catch 22, move setting to config file #346

alerque opened this issue May 6, 2021 · 2 comments

Comments

@alerque
Copy link
Contributor

alerque commented May 6, 2021

The current arrangement has the root domain setting used to generate URLs, including it seems internal api calls or redirects, is currently stored in the database and configured through the UI. The UI won't function at all through a proxy until this is configured correctly. This makes it very hard to get setup initially in a proxy situation because you can't skip straight to running the it should be in the end, you have to start with some localhost access or a port binding or something to get the domain setup, then drop that and start over.

Confusingly, during this process when you do set the correct domain, saving the settings page results in an error (because it can't find the site at the new location) and any settings changed at the same time after the domain change will be lost entirely.

I suggest moving this setting out of the database and run time UI entirely and moving it to the config filed under [app] or wherever. This will make it a lot easier to get up and running with a proxy in the loop without first bootstrapping through some other configuration.

@knadh
Copy link
Owner

knadh commented May 6, 2021

The issue isn't the URL being in the DB but the subpaths being hardcoded in the frontend JS build. See: #174

@knadh
Copy link
Owner

knadh commented Oct 10, 2021

including it seems internal api calls or redirects, is currently stored in the database and configured through the UI.

Closing this issue as the root URL in settings is not used for making API calls or redirects but for generating URLs used in campaigns.

@knadh knadh closed this as completed Oct 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants