Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

send later ignores scheduled time on heroku #516

Closed
uurcank opened this issue Oct 15, 2021 · 12 comments
Closed

send later ignores scheduled time on heroku #516

uurcank opened this issue Oct 15, 2021 · 12 comments
Labels
needs-investigation Potential bug. Needs investigation

Comments

@uurcank
Copy link

uurcank commented Oct 15, 2021

Version:

  • listmonk: 2.0.0
  • OS: Deployed to Heroku

Description of the bug and steps to reproduce:
Send later sends emails instantly regardless of time selection.

Deploy to Heroku button may be skipping to add background workers. And there is no information in docs how to add later.

@uurcank uurcank added the bug Something isn't working label Oct 15, 2021
@knadh
Copy link
Owner

knadh commented Oct 16, 2021

The following screenshot is from a Heroku deployment. There is no additional configuration or backround workers (listmonk uses multi-threading) required. Perhaps this has something to do with timezones or 24H time format?

image

@knadh knadh closed this as completed Oct 16, 2021
@knadh knadh removed the bug Something isn't working label Oct 16, 2021
@uurcank
Copy link
Author

uurcank commented Oct 17, 2021

@knadh I tested this again and it instantly runs the campaign. Scheduling does not work for me. Scheduled for 17 hours later but it was still sent.

Campaigns-listmonk

Do I need to deploy any recent changes from https://github.com/knadh/listmonk-heroku ?

@uurcank
Copy link
Author

uurcank commented Oct 17, 2021

Campaigns-listmonk (1)

@knadh
Copy link
Owner

knadh commented Oct 18, 2021

You are running v2.0.0, right? Can you try scheduling for day + 1 and see if it still triggers?

@knadh knadh reopened this Oct 18, 2021
@uurcank
Copy link
Author

uurcank commented Oct 18, 2021

scheduled for +3 days and it still did

Campaigns-listmonk (2)

@uurcank
Copy link
Author

uurcank commented Oct 18, 2021

I am on v2.0.0

@uurcank
Copy link
Author

uurcank commented Oct 18, 2021

here is the output from logs

2021/10/17 11:51:02v2.0.0 (05585b7 2021-09-27T17:59:39Z)
2021/10/17 11:51:02reading config: config.toml
2021/10/17 11:51:02connecting to db: ec2-52-70-120-204.compute-1.amazonaws.com:5432/xxxxx
2021/10/17 11:51:02media upload provider: s3
2021/10/17 11:51:02loaded email (SMTP) messenger: XXXX@email-smtp.us-east-1.amazonaws.com
2021/10/17 22:18:27start processing campaign (Copy of October Digest 2021)
2021/10/17 22:18:27campaign (Copy of October Digest 2021) finished
2021/10/18 06:59:03error registering campaign view: pq: null value in column "campaign_id" of relation "campaign_views" violates not-null constraint
2021/10/18 06:59:15error registering campaign view: pq: null value in column "campaign_id" of relation "campaign_views" violates not-null constraint
2021/10/18 11:07:12start processing campaign (Copy of October Digest 2021)
2021/10/18 11:07:12campaign (Copy of October Digest 2021) finished

@knadh
Copy link
Owner

knadh commented Oct 18, 2021

This is strange. Can you confirm that the timestamps on the log are correct?

@knadh knadh added the needs-investigation Potential bug. Needs investigation label Oct 18, 2021
@uurcank
Copy link
Author

uurcank commented Oct 18, 2021

timestamps in logs seem to be UTC time, not my timezone.

@knadh
Copy link
Owner

knadh commented Oct 23, 2021

I tried this on a Heroku instance and I'm unable to reproduce the problem.

  • Create new campaign. Populate with dummy content.
  • Pick a schedule.
  • Save changes.
  • Click on the Schedule icon on the campaigns list (or the 'Schedule' button the campaign's page)

image

Can you confirm that you're following the exact steps?

@knadh knadh closed this as completed Nov 5, 2021
@uurcank
Copy link
Author

uurcank commented Nov 6, 2021

@knadh I tested it again using your instructions, and it works. So this is a user interface issue. I never considered pressing "save" first. It is not anticipated.

The "Start campaign" button should submit the form and schedule or start the campaign at the same time. Saving is useful to create a draft that you can work on later.

@knadh
Copy link
Owner

knadh commented Nov 7, 2021

Ah, got it. Fixed the behaviour. Thanks @uurcank

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-investigation Potential bug. Needs investigation
Projects
None yet
Development

No branches or pull requests

2 participants