Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When auth is disabled, hide login button and make logout link customizable #821

Closed
gramakri opened this issue May 30, 2022 · 2 comments
Closed
Labels
enhancement New feature or request

Comments

@gramakri
Copy link

Is your feature request related to a problem? Please describe.
When admin username and password are set to null, the Login page is still shown. Clicking the login button let's us login without any password.

Describe the solution you'd like
Ideally, the Login page is not shown at all. I am trying to package Listmonk for Cloudron, we have a login proxy that provides the authentication for apps without user management. However, after logging in via the proxy, Listmonk still shows the Login button. Clicking the Login button does login but there are two Login clicks required now to login.

Also, the Logout button should be made customizable with a URL to logout via the proxy. Currently, it goes back to Login button view.

@gramakri gramakri added the enhancement New feature or request label May 30, 2022
@knadh
Copy link
Owner

knadh commented May 30, 2022

Disabling auth is meant only for backwards compatibility. A proper multi-user auth and permission system is on the todo (#543).

Ideally, the Login page is not shown at all.

Yep, it is just a static landing page which is a placeholder for a future login system. There's no session management right now to skip the login page. In your setup, is it possible to always route / to /admin? That'll solve the issue.

@gramakri
Copy link
Author

@knadh Thanks for the info, I didn't realize that disabling auth was for backward compat (I guess listmonk started out with no auth at all). Routing to /admin should work (but I think we will probably wait for #543).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants