Implement KafkaSink finalizer #158
Assignees
Comments
|
@pierDipi I think this approach is fine, go for it |
|
/assign |
matzew
pushed a commit
to matzew/eventing-kafka-broker
that referenced
this issue
Apr 7, 2022
…native-extensions#158) * [release-v1.2] KafkaSource lease remapping (knative-extensions#155) * KafkaChannel and KafkaSource lease remappings (knative-extensions#2009) Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com> * Comment out KafkaChannel lease test Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com> * Support knative/pkg#2411 via vendor patch Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com> * Run make generate-release RELEASE=v1.1.3 Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com> * Update patches to use 1.2 Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com> * Fix recent import change Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Problem
We haven't implemented the finalizer in this PR: #134
Persona:
Which persona is this feature for?
*Exit Criteria
A measurable (binary) test that would indicate that the problem has been resolved.
finalizer + unit testsTime Estimate (optional):
How many developer-days do you think this may take to resolve?
1
Additional context (optional)
The underlying topic might be managed by an external entity (eg it might be created before the CO is created), we need to make sure that we don't delete the topic if it isn't managed by us. To do that we can use the annotation
eventing.knative.dev/topic.ownerin the status of the KafkaSink. Possible values of this annotation might be:kafkasink-controllerif it's managed by usexternalif it's notcc @matzew @slinkydeveloper if you would like to share your opinion on the additional context design/discussion.
The text was updated successfully, but these errors were encountered: