Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass pod names as env var in deployments for logging purposes #192

Closed
aliok opened this issue Sep 18, 2020 · 1 comment · Fixed by #191
Closed

Pass pod names as env var in deployments for logging purposes #192

aliok opened this issue Sep 18, 2020 · 1 comment · Fixed by #191
Assignees
@pierDipi
Labels
kind/feature-request

Comments

@aliok
Copy link
Member

aliok commented Sep 18, 2020

Problem
With knative/pkg#1714, pod names passed as env vars are used in logging.

Persona:
Which persona is this feature for?

Exit Criteria
Pod name passed as env vars properly to pods in deployments.

Time Estimate (optional):
0.125

Additional context (optional)
Ref impl: knative/eventing#4072
@pierDipi
Copy link
Member

#191
/assign

@pierDipi pierDipi mentioned this issue Sep 18, 2020
Merged
pierDipi referenced this issue in pierDipi/eventing-kafka-broker Apr 21, 2022
@openshift-cherrypick-robot @pierDipi
Fix resource name servicemonitors (#192)
f59a329 
We were using the Kind name instead of the resource name.

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>

Co-authored-by: Pierangelo Di Pilato <pierdipi@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pierDipi pierDipi

Labels
kind/feature-request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Project pod name as env var in our deployments pierDipi/eventing-kafka-broker
2 participants
@aliok @pierDipi