Inject the pod name into logger when provided in the envvars #1714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deployments that are H(P)A need to provide the pod name envvar via downward api. Activator and QP are already doing this.
knative-prow-robot
added
the
size/S
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vagababov The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow-robot
added
the
approved
vagababov
added a commit
to vagababov/serving
that referenced
this pull request
Sep 17, 2020
This should fix knative/pkg#1408 (comment), once the parent PKG PR merges in (knative/pkg#1714)
|
/lgtm |
knative-prow-robot
pushed a commit
to knative/serving
that referenced
this pull request
Sep 17, 2020
This should fix knative/pkg#1408 (comment), once the parent PKG PR merges in (knative/pkg#1714)
pierDipi
added a commit
to pierDipi/eventing-kafka-broker
that referenced
this pull request
Sep 18, 2020
- knative/pkg#1714 Signed-off-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com>
pierDipi
added a commit
to pierDipi/eventing-kafka-broker
that referenced
this pull request
Sep 18, 2020
- knative/pkg#1714 Signed-off-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com>
pierDipi
added a commit
to pierDipi/eventing
that referenced
this pull request
Sep 18, 2020
- knative/pkg#1714 Signed-off-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com>
This was referenced Sep 18, 2020
Closed
Closed
Closed
Closed
Closed
This was referenced Sep 18, 2020
Closed
Closed
knative-prow-robot
pushed a commit
to knative-extensions/eventing-kafka-broker
that referenced
this pull request
Sep 18, 2020
* Project pod name as env var in our controller - knative/pkg#1714 Signed-off-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com> * Format YAML Signed-off-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com>
knative-prow-robot
pushed a commit
to knative/eventing
that referenced
this pull request
Sep 18, 2020
- knative/pkg#1714 Signed-off-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deployments that are H(P)A need to provide the pod name envvar via downward api.
Activator and QP are already doing this.
For #1408
/assign @dprotaso mattmoor