Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to latest eventing, fix Trigger DeadLetterSinkURI #1150

Merged
merged 1 commit into from Aug 20, 2021

Conversation

benmoss
Copy link
Contributor

@benmoss benmoss commented Aug 19, 2021

Bump eventing with the latest breaking changes from knative/eventing#5642

@google-cla google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label Aug 19, 2021
@knative-prow-robot knative-prow-robot added area/control-plane size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Aug 19, 2021
@codecov
Copy link

codecov bot commented Aug 19, 2021

Codecov Report

Merging #1150 (24ba8a5) into main (fa23f7f) will increase coverage by 4.21%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1150      +/-   ##
============================================
+ Coverage     75.83%   80.04%   +4.21%     
- Complexity      459      460       +1     
============================================
  Files            87       58      -29     
  Lines          3033     1654    -1379     
  Branches        136      136              
============================================
- Hits           2300     1324     -976     
+ Misses          568      260     -308     
+ Partials        165       70      -95     
Flag Coverage Δ
java-unittests 80.04% <ø> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
control-plane/pkg/security/config.go
control-plane/pkg/core/config/utils.go
control-plane/pkg/reconciler/broker/broker.go
control-plane/pkg/reconciler/base/reconciler.go
...pkg/apis/eventing/v1alpha1/kafka_sink_lifecycle.go
control-plane/pkg/security/secret.go
control-plane/pkg/receiver/path.go
control-plane/pkg/core/config/resource.go
control-plane/pkg/kafka/consumer_group_lag.go
...ane/pkg/apis/eventing/v1alpha1/kafka_sink_types.go
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa23f7f...24ba8a5. Read the comment docs.

Copy link
Contributor

@matzew matzew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 20, 2021
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: benmoss, matzew

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 20, 2021
@knative-prow-robot knative-prow-robot merged commit cb0d7a0 into knative-extensions:main Aug 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/control-plane cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants