Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix DeadLetterSink on Trigger status #5642

Merged
merged 1 commit into from Aug 19, 2021
Merged

Fix DeadLetterSink on Trigger status #5642

merged 1 commit into from Aug 19, 2021

Conversation

benmoss
Copy link
Member

@benmoss benmoss commented Aug 18, 2021 •
edited

I mistakenly hadn't added it to the CRD, so it was just getting dropped by the apiserver as an unknown field.

Semi-fixes #5639, I think there still remains the problem that Broker doesn't have a status.deadLetterSinkUri as referenced by the spec

Proposed Changes

  • 馃悰 Fix DeadLetterSinkURI not persisting to Trigger status

Release Note

:page_facing_up: Fix DeadLetterSinkURI not persisting to Trigger status

@google-cla google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label Aug 18, 2021
@knative-prow-robot knative-prow-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 18, 2021
Fix DeadLetterSink on Trigger status
16b7086 
Mistakenly hadn't added it to the CRD, so it was just getting dropped by
the apiserver. Luckily this means we shouldn't have any backwards
compatibility issues :).
@codecov
Copy link

codecov bot commented Aug 18, 2021 •
edited

Codecov Report

Merging #5642 (16b7086) into main (c183833) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #5642   +/-   ##
=======================================
  Coverage   82.73%   82.73%           
=======================================
  Files         200      200           
  Lines        6266     6266           
=======================================
  Hits         5184     5184           
  Misses        750      750           
  Partials      332      332
Impacted Files Coverage 螖
pkg/apis/eventing/v1/trigger_types.go 100.00% <酶> (酶)
pkg/reconciler/broker/trigger/trigger.go 82.31% <100.00%> (酶)

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update c183833...16b7086. Read the comment docs.

@lionelvillard
Copy link
Member

/approve
/lgtm
/hold

may want to coordinate with downstream repos to fix the build breakage. /cc @pierDipi @aliok

@knative-prow-robot knative-prow-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 18, 2021
@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 18, 2021
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: benmoss, lionelvillard

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 18, 2021
@benmoss
Copy link
Member Author

benmoss commented Aug 19, 2021 •
edited

/hold cancel

spoke to @pierDipi and it sounds like we can just merge, I'll PR to fix downstreams

@knative-prow-robot knative-prow-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 19, 2021
@knative-prow-robot knative-prow-robot merged commit 19fcdf4 into knative:main Aug 19, 2021
@benmoss benmoss deleted the trigger-dls branch August 19, 2021 16:06
This was referenced Aug 19, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@lionelvillard lionelvillard

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Trigger deadLetterUri does not conform to specification, should be deadLetterSinkUri
3 participants
@benmoss @lionelvillard @knative-prow-robot