Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.4] Prober targets service instead of pods directly #2158

Conversation

knative-prow-robot
Copy link
Contributor

This is an automated cherry-pick of #2112

Receiver's prober targets services instead of pods directly to allow components to be part of an Istio mesh

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
@knative-prow knative-prow bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. area/control-plane area/data-plane labels May 5, 2022
@codecov
Copy link

codecov bot commented May 5, 2022

Codecov Report

Merging #2158 (c0cbba0) into release-1.4 (9f516ca) will increase coverage by 5.41%.
The diff coverage is 95.23%.

@@                Coverage Diff                @@
##             release-1.4    #2158      +/-   ##
=================================================
+ Coverage          61.18%   66.60%   +5.41%     
- Complexity             0      677     +677     
=================================================
  Files                 70      142      +72     
  Lines               6841     9147    +2306     
  Branches               0      196     +196     
=================================================
+ Hits                4186     6092    +1906     
- Misses              2356     2650     +294     
- Partials             299      405     +106     
Flag Coverage Δ
java-unittests 82.58% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
control-plane/pkg/prober/async_prober.go 88.88% <88.88%> (+0.13%) ⬆️
control-plane/pkg/prober/prober.go 67.74% <100.00%> (+4.77%) ⬆️
control-plane/pkg/reconciler/broker/controller.go 82.55% <100.00%> (+0.20%) ⬆️
control-plane/pkg/reconciler/channel/controller.go 89.02% <100.00%> (+0.13%) ⬆️
...ol-plane/pkg/reconciler/channel/v2/controllerv2.go 100.00% <100.00%> (ø)
control-plane/pkg/reconciler/sink/controller.go 77.94% <100.00%> (+0.32%) ⬆️
...lane/pkg/reconciler/consumergroup/consumergroup.go 76.52% <0.00%> (ø)
...ceiver/impl/handler/IngressRequestHandlerImpl.java 100.00% <0.00%> (ø)
...cher/impl/filter/subscriptionsapi/ExactFilter.java 100.00% <0.00%> (ø)
...atcher/impl/consumer/KafkaConsumerRecordUtils.java 100.00% <0.00%> (ø)
... and 70 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f516ca...c0cbba0. Read the comment docs.

Copy link
Contributor

@matzew matzew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label May 5, 2022
@knative-prow
Copy link

knative-prow bot commented May 5, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: knative-prow-robot, matzew

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 5, 2022
@matzew
Copy link
Contributor

matzew commented May 5, 2022

/retest-required

@knative-prow knative-prow bot merged commit ebee147 into knative-extensions:release-1.4 May 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/control-plane area/data-plane lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants