-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-1.4] Prober targets service instead of pods directly #2158
[release-1.4] Prober targets service instead of pods directly #2158
Conversation
Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
Codecov Report
@@ Coverage Diff @@
## release-1.4 #2158 +/- ##
=================================================
+ Coverage 61.18% 66.60% +5.41%
- Complexity 0 677 +677
=================================================
Files 70 142 +72
Lines 6841 9147 +2306
Branches 0 196 +196
=================================================
+ Hits 4186 6092 +1906
- Misses 2356 2650 +294
- Partials 299 405 +106
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: knative-prow-robot, matzew The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest-required |
This is an automated cherry-pick of #2112