-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prober targets service instead of pods directly #2112
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2112 +/- ##
============================================
+ Coverage 66.55% 66.60% +0.04%
- Complexity 676 677 +1
============================================
Files 142 142
Lines 9138 9147 +9
Branches 196 196
============================================
+ Hits 6082 6092 +10
+ Misses 2651 2650 -1
Partials 405 405
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
/test unit-tests_eventing-kafka-broker_main |
Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
LGTM but, I'd like to see some feedback on if the patch worked in your environment, @LeonardAukea |
@markhulia how is it going with the tests? |
The patch worked #2107 (comment) /cherry-pick release-v1.4 |
@pierDipi: once the present PR merges, I will cherry-pick it on top of release-v1.4 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherry-pick release-1.4 |
@pierDipi: once the present PR merges, I will cherry-pick it on top of release-1.4 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherry-pick release-1.3 |
@pierDipi: once the present PR merges, I will cherry-pick it on top of release-1.3 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cc @matzew |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: matzew, pierDipi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@pierDipi: new pull request created: #2158 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@pierDipi: new pull request created: #2159 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@pierDipi: cannot checkout In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
…sions#2112) (#250) * Prober targets service instead of pods directly (knative-extensions#2112) Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com> * Run make generate-release Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
…ve-extensions#2112) (#257) * Prober targets service instead of pods directly (knative-extensions#2112) Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com> * Run make generate-release Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com> Co-authored-by: Pierangelo Di Pilato <pierdipi@redhat.com>
/cherry-pick release-1.2 |
@pierDipi: #2112 failed to apply on top of branch "release-1.2":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Manual cherry pick into 1.2 branch: #2180 |
Istio doesn't work well when there is pod to pod communication.
Signed-off-by: Pierangelo Di Pilato pierdipi@redhat.com
Fixes #2107
Proposed Changes
Release Note