Avoid possible nil pointer dereferences in consumergroup scheduling #3775
Conversation
… scheduling Signed-off-by: Calum Murray <cmurray@redhat.com>
knative-prow
bot
added
size/S
knative-prow
bot
requested review from
odacremolbap,
pierDipi,
creydr and
Leo6Leo
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3775 +/- ##
============================================
- Coverage 52.45% 52.43% -0.03%
+ Complexity 877 875 -2
============================================
Files 343 343
Lines 21451 21458 +7
Branches 288 288
============================================
- Hits 11253 11251 -2
- Misses 9288 9294 +6
- Partials 910 913 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Calum Murray <cmurray@redhat.com>
knative-prow
bot
added
size/M
|
/cherry-pick release-1.13 |
|
@Cali0707: once the present PR merges, I will cherry-pick it on top of release-1.13 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherry-pick release-1.12 |
|
@Cali0707: once the present PR merges, I will cherry-pick it on top of release-1.12 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/hold |
knative-prow
bot
added
the
do-not-merge/hold
Signed-off-by: Calum Murray <cmurray@redhat.com>
Signed-off-by: Calum Murray <cmurray@redhat.com>
knative-prow
bot
added
size/L
|
/unhold |
knative-prow
bot
removed
the
do-not-merge/hold
|
/retest-required |
|
/retest |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Cali0707, pierDipi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest-required |
knative-prow
bot
merged commit 5cfcbda
into
knative-extensions:main
|
@Cali0707: new pull request created: #3785 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@Cali0707: new pull request created: #3786 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
…native-extensions#3775) * fix: avoiding some possible nil pointer dereferences in consumergroup scheduling Signed-off-by: Calum Murray <cmurray@redhat.com> * fixed unit tests Signed-off-by: Calum Murray <cmurray@redhat.com> * ignore no scheduler found error on finaliztion Signed-off-by: Calum Murray <cmurray@redhat.com> * address review comments Signed-off-by: Calum Murray <cmurray@redhat.com> --------- Signed-off-by: Calum Murray <cmurray@redhat.com>
…native-extensions#3775) (#1046) * fix: avoiding some possible nil pointer dereferences in consumergroup scheduling * fixed unit tests * ignore no scheduler found error on finaliztion * address review comments --------- Signed-off-by: Calum Murray <cmurray@redhat.com>
Maybe fixes the panic seen in https://storage.googleapis.com/knative-prow/pr-logs/pull/knative-extensions_eventing-kafka-broker/3558/upgrade-tests_eventing-kafka-broker_main/1769808258517700608/artifacts/new-logs/kafka-controller-8565b5bfd7-ffw6g-controller-2024-03-18%2019:58:12.178049569%20+0000%20UTC%20m=+537.848531106.log
Proposed Changes