-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-1.13] Avoid possible nil pointer dereferences in consumergroup scheduling #3785
[release-1.13] Avoid possible nil pointer dereferences in consumergroup scheduling #3785
Conversation
… scheduling Signed-off-by: Calum Murray <cmurray@redhat.com>
Signed-off-by: Calum Murray <cmurray@redhat.com>
Signed-off-by: Calum Murray <cmurray@redhat.com>
Signed-off-by: Calum Murray <cmurray@redhat.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release-1.13 #3785 +/- ##
==================================================
+ Coverage 48.41% 52.43% +4.01%
- Complexity 0 845 +845
==================================================
Files 241 338 +97
Lines 17545 20759 +3214
Branches 0 273 +273
==================================================
+ Hits 8494 10884 +2390
- Misses 8337 8993 +656
- Partials 714 882 +168
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Cali0707, knative-prow-robot The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest-required |
/test reconciler-tests |
9acb72f
into
knative-extensions:release-1.13
This is an automated cherry-pick of #3775