Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.13] Avoid possible nil pointer dereferences in consumergroup scheduling #3785

Conversation

knative-prow-robot
Copy link
Contributor

This is an automated cherry-pick of #3775

… scheduling

Signed-off-by: Calum Murray <cmurray@redhat.com>
Signed-off-by: Calum Murray <cmurray@redhat.com>
Signed-off-by: Calum Murray <cmurray@redhat.com>
Signed-off-by: Calum Murray <cmurray@redhat.com>
@knative-prow knative-prow bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 25, 2024
Copy link

codecov bot commented Mar 25, 2024

Codecov Report

Attention: Patch coverage is 53.33333% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 52.43%. Comparing base (c9a7165) to head (de56581).

Files Patch % Lines
...lane/pkg/reconciler/consumergroup/consumergroup.go 57.14% 4 Missing and 2 partials ⚠️
...l-plane/pkg/reconciler/consumergroup/controller.go 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@                Coverage Diff                 @@
##             release-1.13    #3785      +/-   ##
==================================================
+ Coverage           48.41%   52.43%   +4.01%     
- Complexity              0      845     +845     
==================================================
  Files                 241      338      +97     
  Lines               17545    20759    +3214     
  Branches                0      273     +273     
==================================================
+ Hits                 8494    10884    +2390     
- Misses               8337     8993     +656     
- Partials              714      882     +168     
Flag Coverage Δ
java-unittests 74.36% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@Cali0707 Cali0707 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Mar 25, 2024
Copy link

knative-prow bot commented Mar 25, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Cali0707, knative-prow-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 25, 2024
@Cali0707
Copy link
Member

/retest-required

@matzew
Copy link
Contributor

matzew commented Mar 26, 2024

/test reconciler-tests

@knative-prow knative-prow bot merged commit 9acb72f into knative-extensions:release-1.13 Mar 26, 2024
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/control-plane lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants